I want to ask if i change my online id on ps4 will i lose my genshin impact account?
Theoretically no, but before you change, you will be informed by sony that the change may affect your purchases. You may then no longer be able to use individual applications because they are registered on a different online ID, what can still happen is that all of the saved games become unusable sone is a backup from sony that already existed on ps3 so that no one can steal or copy other players' scores, so think twice about whether you really want to do that