Are Xbox games lost?

Are Xbox one games lost after a while?

I say no.

If you bought it then you have it forever unless Microsoft takes the servers down (if it's an online game)

Not is forever. Whether you still have access to your libraries, assuming 30 years from now, is probably a gamble.