Lastly, I did my xbox one s controller on my cable (I often do it) because we had no batteries there. And eventually the controller started to stink.
So after expired battery. And it does not work then. At the beginning we thought it was up to something else but then we did our other controller and the same thing happened.
What exactly is this happening please and can you still save it?
"Starts to stink" is a very bad sign…
Are you sure that there are no batteries in there? Maybe there are not chargeable in there, you have brought with the cable to leak?
If in fact there were no batteries in it: What is the cable connected to? At the XBox or at a power outlet?
With the XBox you should examine the slot times, if necessary change and with the socket I would change for safety's sake the USB adapter times. Changing the cable could not hurt either.
The controllers you can most likely throw away…